Merge setup.cfg, tox.ini into pyproject.toml and use dependency groups#322
Merged
dstansby merged 11 commits intomatplotlib:mainfrom Feb 2, 2026
Merged
Merge setup.cfg, tox.ini into pyproject.toml and use dependency groups#322dstansby merged 11 commits intomatplotlib:mainfrom
dstansby merged 11 commits intomatplotlib:mainfrom
Conversation
dstansby
requested changes
Feb 1, 2026
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Looks good overall - I spotted one typo, hence request changes, but the rest looks good 👍
pyproject.toml
Outdated
| "tox", | ||
| "pytest-xvfb; sys_platform == 'linux'", | ||
| ] | ||
| dev = [ |
Member
There was a problem hiding this comment.
Could this instead be ["napari-matplotlib[test]", "napar-matplotlib[docs]"] to avoid duplication?
Collaborator
Author
There was a problem hiding this comment.
Yes, you can have that!
The syntax is a bit different. It would be:
dev = [
{include-group = "test"},
{include-group = "docs"},
]
but agree that we don't want to literally WET.
samcunliffe
commented
Feb 2, 2026
samcunliffe
commented
Feb 2, 2026
samcunliffe
commented
Feb 2, 2026
samcunliffe
commented
Feb 2, 2026
samcunliffe
commented
Feb 2, 2026
dstansby
approved these changes
Feb 2, 2026
Collaborator
Author
|
@jaideepkathiresan thanks for the contribution! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retry of
Should wait for